Fixed additional '@' in DoctrineTokenProvider service in 'Remember Me' functionality #11459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vertisan good catch! This can be verified in the related Symfony code: https://github.com/symfony/symfony/blob/e479b6902e2f3be2c802f846f220eeb119a82aa0/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/RememberMeFactory.php#L65-L69 Thank you! By the way, there's no need to create another PR for the 'master' branch. We always "upmerge" pull requests from lower branches up to master. |
javiereguiluz
added a commit
that referenced
this pull request
Apr 23, 2019
… 'Remember Me' functionality (vertisan) This PR was submitted for the 4.2 branch but it was merged into the 3.4 branch instead (closes #11459). Discussion ---------- Fixed additional '@' in DoctrineTokenProvider service in 'Remember Me' functionality In current version we have to add the following line into our firewall definitions: ```yaml token_provider: '@symfony\Bridge\Doctrine\Security\RememberMe\DoctrineTokenProvider' ``` but with this we'll get error: ``` The service "security.authentication.rememberme.services.persistent.main" has a dependency on a non-existent service "@symfony\Bridge\Doctrine\Security\RememberMe\DoctrineTokenProvider". ``` To fix this we need to remove `@` character from service definition so finally it should looks like: ```yaml token_provider: 'Symfony\Bridge\Doctrine\Security\RememberMe\DoctrineTokenProvider' ``` P.S. I have already commit for `master` branch too so if this change will be accepted, I'll create pull request for `master` too. Commits ------- 9e137fd Fixed additional '@' in DoctrineTokenProvider service in 'Remember Me' functionality
|
Note: we finally merged this in 3.4 (and then we'll merge it in 4.2 and master). That's why GitHub shows it as closed instead of merged (because we changed the branch while merging) ... but it's merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current version we have to add the following line into our firewall definitions:
but with this we'll get error:
To fix this we need to remove
@character from service definition so finally it should looks like:P.S. I have already commit for
masterbranch too so if this change will be accepted, I'll create pull request formastertoo.