Skip to content

Fix tab content displaying #11362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Fix tab content displaying #11362

merged 1 commit into from
Apr 8, 2019

Conversation

tyx
Copy link
Contributor

@tyx tyx commented Apr 8, 2019

Apparently the double : leads to displaying .. configuration-block:: instead of interprating it.

I tested in local with docker :

Before

After

Apparently the double `:` leads to displaying `.. configuration-block::` instead of interprating it.

I tested in local with docker : 

Before
![](https://screenshotscdn.firefoxusercontent.com/images/da8667a4-3eba-42b0-b466-236eb129931b.png)

After

![](https://screenshotscdn.firefoxusercontent.com/images/dd4b3c66-99a2-4e1d-bf65-463ab4df69af.png)
@javiereguiluz
Copy link
Member

Good catch! The double colon must only be placed before a PHP code block. Thanks for fixing it!

@javiereguiluz javiereguiluz merged commit adc611a into symfony:3.4 Apr 8, 2019
javiereguiluz added a commit that referenced this pull request Apr 8, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

Fix tab content displaying

Apparently the double `:` leads to displaying `.. configuration-block::` instead of interprating it.

I tested in local with docker :

Before
![](https://screenshotscdn.firefoxusercontent.com/images/da8667a4-3eba-42b0-b466-236eb129931b.png)

After

![](https://screenshotscdn.firefoxusercontent.com/images/dd4b3c66-99a2-4e1d-bf65-463ab4df69af.png)

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

adc611a Fix tab content displaying
@tyx tyx deleted the patch-1 branch April 8, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants