Skip to content

Link to review comments documentation #11325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

michellesanver
Copy link
Contributor

The reviews comment documentation can be difficult to find, adding this link will help to get more people read through it. Which will in the end hopefully lead to less misunderstandings :)

Copy link
Contributor

@linaori linaori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@dbrumann dbrumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@wouterj wouterj added the ⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming label Apr 6, 2019
The reviews comment documentation can be difficult to find, adding this link will help
more people read through it.
@wouterj wouterj changed the base branch from master to 3.4 April 6, 2019 18:57
@xabbuh xabbuh added this to the 3.4 milestone Apr 6, 2019
@wouterj wouterj closed this in a4d75d7 Apr 6, 2019
wouterj added a commit that referenced this pull request Apr 6, 2019
wouterj added a commit that referenced this pull request Apr 6, 2019
* 3.4:
  [#11325] Use correct line lengths
  Link to review comments documentation
  escape backslashes in class role
wouterj added a commit that referenced this pull request Apr 6, 2019
* 4.2:
  [#11325] Use correct line lengths
  Link to review comments documentation
wouterj added a commit that referenced this pull request Apr 6, 2019
wouterj added a commit that referenced this pull request Apr 6, 2019
* 4.2:
  [#11325] Use correct line lengths
  Link to review comments documentation
xabbuh added a commit that referenced this pull request Apr 6, 2019
* 3.4:
  [#11310] fix reference
  [#11325] Use correct line lengths
  Link to review comments documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming Status: Reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants