Skip to content

try to make the code examples less noisy #11281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2019
Merged

try to make the code examples less noisy #11281

merged 1 commit into from
Apr 4, 2019

Conversation

OskarStark
Copy link
Contributor

No description provided.

@OskarStark OskarStark added this to the 3.4 milestone Apr 3, 2019
@javiereguiluz javiereguiluz merged commit 22497ec into symfony:3.4 Apr 4, 2019
javiereguiluz added a commit that referenced this pull request Apr 4, 2019
@javiereguiluz
minor #11281 try to make the code examples less noisy (OskarStark)
f40aa53 
This PR was merged into the 3.4 branch.

Discussion
----------

try to make the code examples less noisy

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

22497ec try to make the code examples less noisy
@javiereguiluz
Copy link
Member

Thanks Oskar! While merging I changed this to use a configuration-block directive.

@OskarStark
Copy link
Contributor Author

I changed this to use a configuration-block directive.

I thought about this as well, but currently we are using XML to show XML content and not HOW to parse an XML file, I am also not sure how the syntax will be highlighted if you are showing php code in an XML lexed block. Can you please double check this?

And as the tabs are saved, only because I am using xml for my config files, I dont want to parse only xml files via the XmlLoader....

@OskarStark OskarStark deleted the less-noisy branch April 4, 2019 07:18
@javiereguiluz
Copy link
Member

Wow! I was totally wrong. You are right: this is about XML, but it's not XML but PHP 🤦‍♂️ I'm going to fix it.

@javiereguiluz javiereguiluz mentioned this pull request Apr 4, 2019
Merged
javiereguiluz added a commit that referenced this pull request Apr 4, 2019
@javiereguiluz
minor #11294 Fixed the RST syntax of a serializer article (javieregui…
5a575f6 
…luz)

This PR was merged into the 3.4 branch.

Discussion
----------

Fixed the RST syntax of a serializer article

Fixes the issue I introduced while merging #11281.

Commits
-------

821d156 Fixed the RST syntax of a serializer article
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Serializer Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@OskarStark @javiereguiluz @carsonbot