Skip to content

fix filepaths for code examples #11255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2019
Merged

fix filepaths for code examples #11255

merged 1 commit into from
Apr 5, 2019

Conversation

OskarStark
Copy link
Contributor

No description provided.

@OskarStark OskarStark added this to the 4.3 milestone Apr 1, 2019
@OskarStark OskarStark modified the milestones: 4.3, 3.4 Apr 1, 2019
@javiereguiluz
Copy link
Member

javiereguiluz commented Apr 1, 2019 •
edited
Loading

Thanks for this! I agree with the micro_kernel_trait.rst changes ... but the changes in the form article are not entirely correct. In 3.4 branch we still use the AppBundle thing ... so instead of removing App, we must replace it with AppBundle.

Note when merging this up: in 4.2 branch we must remove AppBundle and leave only src/Form/... so, after you make the git checkout 4.2 && git merge --log 3.4, make these changes and then you can do the git commit -a && git push ...

@OskarStark OskarStark force-pushed the fix-filepath-for-code-examples branch from a2fceb6 to 3282128 Compare April 1, 2019 19:10
@OskarStark OskarStark requested a review from xabbuh April 1, 2019 19:10
@OskarStark
Copy link
Contributor Author

Thank you @javiereguiluz, please review again! 👍

@OskarStark OskarStark requested a review from javiereguiluz April 1, 2019 19:11
@javiereguiluz
Copy link
Member

Thanks Oskar!

@javiereguiluz javiereguiluz merged commit 3282128 into symfony:3.4 Apr 5, 2019
javiereguiluz added a commit that referenced this pull request Apr 5, 2019
@javiereguiluz
minor #11255 fix filepaths for code examples (OskarStark)
c5f05cb 
This PR was merged into the 3.4 branch.

Discussion
----------

fix filepaths for code examples

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

3282128 fix filepaths for code examples
@OskarStark OskarStark deleted the fix-filepath-for-code-examples branch December 7, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

@javiereguiluz javiereguiluz Awaiting requested review from javiereguiluz

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@OskarStark @javiereguiluz @carsonbot