Skip to content

minor - controller in app, rather than in bundle #11253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2019
Merged

minor - controller in app, rather than in bundle #11253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion security/form_login.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ First, enable ``form_login`` under your firewall:

Now, when the security system initiates the authentication process, it will
redirect the user to the login form ``/login``. Implementing this login form
is your job. First, create a new ``SecurityController`` inside a bundle::
is your job. First, create a new ``SecurityController`` inside your app::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, good catch!

Could you please change “app” to “application”?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may even remove the entire "inside your app" ... because previously it made sense, but now it looks redundant.


// src/Controller/SecurityController.php
namespace App\Controller;
Expand Down