Skip to content

[Console] uncomment the "Before" code part #11248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2019
Merged

[Console] uncomment the "Before" code part #11248

merged 1 commit into from
Mar 29, 2019

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Mar 29, 2019 •
edited
Loading

for better syntax highlighting

The current version:
Screenshot 2019-03-29 10 58 30

@OskarStark
uncomment the "Before" code part
a9fc18a 
for better syntax highlighting
@OskarStark OskarStark changed the base branch from master to 3.4 March 29, 2019 10:02
@OskarStark OskarStark added this to the 3.4 milestone Mar 29, 2019
javiereguiluz
javiereguiluz approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually do this so people copy+pasting things don't copy unwanted things ... but in this case, even if they do, it'd be harmless because the $io var will just be overridden.

@OskarStark
Copy link
Contributor Author

Ok, good to know for the future, thank you Javier.

@OskarStark OskarStark merged commit a9fc18a into symfony:3.4 Mar 29, 2019
OskarStark added a commit that referenced this pull request Mar 29, 2019
@OskarStark
minor #11248 [Console] uncomment the "Before" code part (OskarStark)
2d77f5d 
This PR was merged into the 3.4 branch.

Discussion
----------

[Console] uncomment the "Before" code part

for better syntax highlighting

The current version:
![Screenshot 2019-03-29 10 58 30](https://user-images.githubusercontent.com/995707/55224862-a48aeb00-5211-11e9-8139-e7bac0f566c8.png)

Commits
-------

a9fc18a uncomment the "Before" code part
@OskarStark OskarStark deleted the uncomment branch March 29, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@OskarStark @javiereguiluz @carsonbot