Improved routing section #11245
Merged
Improved routing section #11245
+31
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
routing.rst
Outdated
|
|
||
| $ composer require annotations | ||
|
|
||
| .. note:: |
There was a problem hiding this comment.
I wouldn't add such a detailed note ... maybe we can move this to a phrase wrapped in parenthesis after the "... run this command once in your app to add support for them:"
OskarStark
requested changes
Mar 29, 2019
OskarStark
reviewed
Apr 6, 2019
security/form_login_setup.rst
Outdated
| @@ -74,6 +74,51 @@ class that processes the login submit and 4) updates the main security config fi | |||
| } | |||
| } | |||
|
|
|||
| Edit the ``security.yml`` file in order to allow access for anyone to the | |||
security/form_login_setup.rst
Outdated
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xmlns:srv="http://symfony.com/schema/dic/services" | ||
| xsi:schemaLocation="http://symfony.com/schema/dic/services | ||
| http://symfony.com/schema/dic/services/services-1.0.xsd"> |
|
@OskarStark If this needs to be fixed in 3.4 I'll do it in another PR. |
OskarStark
approved these changes
Apr 6, 2019
maxhelias
approved these changes
Apr 7, 2019
OskarStark
approved these changes
Apr 7, 2019
javiereguiluz
added a commit
that referenced
this pull request
Apr 24, 2019
|
Jules, I'm sorry it took us so long to merge this. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #11113 in 4.2.