be keen to newcomers #11170
Merged
be keen to newcomers #11170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
reviewed
Mar 16, 2019
OskarStark
force-pushed
the
be-keen-to-newcomers2
branch
from
404fabb to
378d9e8
Compare
pbowyer
reviewed
Mar 23, 2019
| @@ -178,7 +178,7 @@ That's it! Just three lines are needed to render the complete form: | |||
|
|
|||
| .. seealso:: | |||
|
|
|||
| As easy as this is, it's not very flexible (yet). Usually, you'll want to | |||
| As short as this is, it's not very flexible (yet). Usually, you'll want to | |||
There was a problem hiding this comment.
Regarding the (yet): the form shown above is not going to become flexible at a future time. Suggest removing as it's not correct.
There was a problem hiding this comment.
I've made this change while merging. Thanks.
There was a problem hiding this comment.
Thank you Javier 👍🏻
javiereguiluz
added a commit
that referenced
this pull request
Mar 25, 2019
This PR was merged into the 3.4 branch. Discussion ---------- be keen to newcomers Commits ------- 378d9e8 be keen to newcomers
|
Thanks Oskar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.