added missing php before bin/console #11141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be consistent throughout the docs
|
Hmm, being consistent should be adding it everywhere. Otherwise the code in not "copy/pastable" anymore for window users... That's why we add it usually. |
HeahDude
approved these changes
Mar 12, 2019
|
Except these lines now all should have a php prefix for windows users, or did I miss some? |
xabbuh
approved these changes
Mar 12, 2019
|
Thanks Oskar. |
javiereguiluz
added a commit
that referenced
this pull request
Mar 12, 2019
This PR was merged into the 3.4 branch. Discussion ---------- added missing php before bin/console to be consistent throughout the docs <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- a8afae4 added missing php before bin/console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be consistent throughout the docs