Added a note about virtual machine for local build #11115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,3 +33,6 @@ $ docker build . -t symfony-docs | |||
| # (if it's already in use, change the '8080' port by any other port) | |||
| $ docker run --rm -p 8080:80 symfony-docs | |||
| ``` | |||
|
|
|||
| If you use a virtual machine use its ip instead of the localhost to access the | |||
| server (i.e `http://192.168.99.100:8080`). | |||
There was a problem hiding this comment.
What would be the real full command to execute in this case? This one?
docker run --rm -p http://192.168.99.100:8080:80 symfony-docs
There was a problem hiding this comment.
Yes, do you prefer that I inline it all with both the comment below the other one? I hesitated.
There was a problem hiding this comment.
No sorry the command is the same, just the access is different.
There was a problem hiding this comment.
The real diff when using a VM is:
- http://127.0.0.1:8080
+ http://IP_VM:8080
|
Thanks Jules. |
javiereguiluz
added a commit
that referenced
this pull request
Mar 11, 2019
…s Pietri) This PR was merged into the 3.4 branch. Discussion ---------- Added a note about virtual machine for local build <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 091bb22 Added a note about virtual machine for local build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.