-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
adding docs about configurable flex paths #11114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice addition, thanks!
|
||
If you customize these paths, some files copied from a recipe still may contain | ||
references to the original path. In other words: you may need to update some things | ||
manually after a recipe is installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should also note that official recipes do not need such extra treatment, because they use %PUBLIC_DIR%
placeholder.
We could even mention that cause as advice for creating custom/contributed recipes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HeahDude are you saying that using things like %PUBLIC_DIR%
is mandatory for official recipes but not for community recipes? Why? It should be mandatory for both, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you saying that using things like %PUBLIC_DIR% is mandatory for official recipes but not for community recipes
No I'm not 😅
Just saying that we should document that fact too while documenting contrib recipes here https://github.com/symfony/recipes/blob/master/README.rst#copy-from-recipe-configurator.
It's shown in the example but never really explained.
If we were to do it here I suggest to add a note and even a link to that section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I've created symfony/recipes#545 to better explain this ... but I don't think we should add more links between them. Each repo explains this a bit differently to adapt to their readers.
Why did you add this to the 3.4 milestone @HeahDude? |
Yes the target branch should be changed ;). |
Thanks Ryan! Merged it in 3.4. |
Hi friends!
Flex is a bit configurable, but it wasn't documented anywhere.
See https://twitter.com/beausimensen/status/1101863042797789192