Update Custom Constraints documentation #11060
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Class Constraint Validator section, the example that shows how to apply the custom validator to the whole class it's wrong, it applies the ConstraintValidator class instead of the Constraint class to validation.
|
@MendicantBias90 thanks a lot for your contribution. I was going to merge it but when reviewing the changes they felt familiar to me. The reason is that we already merged these changes in a different pull request: #11180. I'm really sorry because your pull request was submitted earlier and we should have merged yours. I'm sorry because it was my fault. This is not common, but it sometimes happens when we receive lots of contributions. We're looking forward to receive more contributions from you in the future. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Class Constraint Validator section, the example that shows how to apply the custom validator to the whole class it's wrong, it applies the ConstraintValidator class instead of the Constraint class to validation.