Skip to content

[HTTP-cache] Added SSI #11024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2019
Merged

[HTTP-cache] Added SSI #11024

merged 1 commit into from
Aug 15, 2019

Conversation

Ioni14
Copy link

@Ioni14 Ioni14 commented Feb 20, 2019

Hello!

This is my first "big" contribution to Symfony docs. :)
It has many similarities with the ESI one but I think it can be better known and used with a specific doc.

I think it's Symfony 2.6 (!) when the SSI feature has been merged, I hope I'm right.

I guess there are many typos, I'll fix them as quickly as possible.

Thanks for reviewing. ;)

@javiereguiluz
Copy link
Member

@Ioni14 thanks for this contribution. I'll try to review it soon.

You are right that this was introduced in Symfony 2.6 ... and it's part of #2129, a pending issue since Symfony 2.2 !!

@javiereguiluz javiereguiluz requested a review from xabbuh June 14, 2019 07:56
@xabbuh xabbuh added this to the 3.4 milestone Jun 14, 2019
@OskarStark OskarStark changed the base branch from master to 4.3 August 15, 2019 10:22
@OskarStark
Copy link
Contributor

Thank you Thomas.

@OskarStark OskarStark merged commit d9cdb9d into symfony:4.3 Aug 15, 2019
OskarStark added a commit that referenced this pull request Aug 15, 2019
This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes #11024).

Discussion
----------

[HTTP-cache] Added SSI

Hello!

This is my first "big" contribution to Symfony docs. :)
It has many similarities with the ESI one but I think it can be better known and used with a specific doc.

I think it's Symfony 2.6 (!) when the SSI feature has been merged, I hope I'm right.

I guess there are many typos, I'll fix them as quickly as possible.

Thanks for reviewing. ;)

Commits
-------

d9cdb9d add http cache SSI
OskarStark added a commit to OskarStark/symfony-docs that referenced this pull request Aug 15, 2019
OskarStark added a commit that referenced this pull request Aug 15, 2019
* 4.3:
  Tweaks #11024
  add http cache SSI
OskarStark added a commit that referenced this pull request Aug 15, 2019
* 4.4:
  Tweaks #11024
  add http cache SSI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants