Skip to content

Show example on using a DateTimeImmutable object #10962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pavlakis
Copy link
Contributor

@pavlakis pavlakis commented Feb 3, 2019

Add an example on using DateTimeImmutable through the input option.

Add an example on using DateTimeImmutable through the `input` option.
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we can merge this

@@ -69,6 +69,14 @@ field as **three different choice fields**::
If your underlying date is *not* a ``DateTime`` object (e.g. it's a unix timestamp),
configure the `input`_ option.

When working with a ``DateTimeImmutable`` object, add this as an ``input`` option::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add a full new paragraph for it. We can update the paragraph above like (e.g. it is DateTimeImmutable object or a UNIX timestamp).

@xabbuh xabbuh added this to the 3.4 milestone Feb 20, 2019
@xabbuh xabbuh added the Form label Feb 20, 2019
javiereguiluz added a commit that referenced this pull request Mar 7, 2019
This PR was submitted for the 4.2 branch but it was merged into the 3.4 branch instead (closes #10962).

Discussion
----------

Show example on using a DateTimeImmutable object

Add an example on using DateTimeImmutable through the `input` option.

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

3bccc62 Show example on using a DateTimeImmutable object
@javiereguiluz
Copy link
Member

@pavlakis thanks for this contribution! I merged it in 3.4 and added the suggestion made by @xabbuh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants