Update sequence_provider.rst #10948
Closed
Update sequence_provider.rst #10948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that is better to explain this difference as someone could misunderstand and think that a group in the sequence, alone, will trigger the validation of all groups in the sequence.
HeahDude
reviewed
Feb 4, 2019
|
Thank you Samuele. |
javiereguiluz
added a commit
that referenced
this pull request
Feb 8, 2019
This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #10948). Discussion ---------- Update sequence_provider.rst I think that is better to explain this difference as someone could misunderstand and think that a group in the sequence, alone, will trigger the validation of all groups in the sequence. Commits ------- 7f5d9c3 Update sequence_provider.rst
|
Why is this closed and not merged @javiereguiluz? 🤔 |
|
Oh, sorry, I've seen only now you referenced this in another commit. |
|
@DonCallisto we use a proprietary tool to merge things. Since we changed the branch while merging (to merge this in 3.4 instead of master) GitHub makes it look "closed" instead of "merged", but it's merged :) We're sorry for the confusion, but I prefer to do things like rebasing myself when merging to not bother contributors. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that is better to explain this difference as someone could misunderstand and think that a group in the sequence, alone, will trigger the validation of all groups in the sequence.