Skip to content

Update testing.rst #10917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Update testing.rst #10917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion email/testing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Start with a simple controller action that sends an email::

$mailer->send($message);

return $this->render(...);
return $this->render();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could probably be replaced with return new Response(); instead? I guess the point here was "return some kind of response".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am 👍 for return new Response here instead of „...“

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the end I replaced this line by // ... because it's not related or needed for the rest of the article.

Copy link

@ghost ghost Jan 28, 2019 •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xavierkaitha94 You could also use GitHub's new suggestion method to quickly change the file on the web accordingly to @kunicmarko20 suggestion.

Suggested change
return $this->render();
return new Response();

}

In your functional test, use the ``swiftmailer`` collector on the profiler
Expand Down