Skip to content

[Validator] Fix @Valid regarding property traverse #10868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2019
Merged

[Validator] Fix @Valid regarding property traverse #10868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions reference/constraints/Valid.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,8 @@ traverse

**type**: ``boolean`` **default**: ``true``

If this constraint is applied to a property that holds an array of objects,
then each object in that array will be validated only if this option is
set to ``true``.
If this constraint is applied to a ``Traversable``, then all containing values
will be validated if this option is set to ``true``. This option is ignored on
arrays: Arrays are traversed in either case. Keys are not validated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should need a correction if symfony/symfony#29800 is merged, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, @Valid is working correctly. The docs could just use this clarification. The mentioned pull request is only concerned with other constraints not working correctly.


.. include:: /reference/constraints/_payload-option.rst.inc