Add missing imports and remove useless #10817
Conversation
| @@ -66,6 +66,8 @@ constructor. If your command defines its own constructor, set the properties | |||
| first and then call to the parent constructor, to make those properties | |||
| available in the ``configure()`` method:: | |||
|
|
|||
| use Symfony\Component\Console\Input\InputArgument; | |||
|
|
|||
| class CreateUserCommand extends Command | |||
There was a problem hiding this comment.
missing command import here
|
@kunicmarko20 yep, there are a lot of places where I observed it and didn't add but there are places where it's better to add 🙂 |
gregurco
force-pushed
the
3.2_fix_imports
branch
from
0db15bb to
a89cfa3
Compare
|
@gregurco thanks a lot for this contribution! There were definitely some important missing imports in some examples. However, in case you are thinking of doing more changes in the future, please keep in mind that we don't want to add all imports in all examples because that would make Symfony Docs unmaintainable. The first example of an article should include all the imports ... but the rest of examples in the same page should only display the new imports and show the rest as |
This PR was merged into the 3.4 branch. Discussion ---------- Add missing imports and remove useless I added importing of classes where it's quite important to provide it and removed where class is imported and not used in code block. Commits ------- a89cfa3 Add missing imports and remove useless
|
@javiereguiluz thank you. I also thought about this strategy 🙂 |
This PR was merged into the 3.4 branch. Discussion ---------- Add missing imports and remove useless I added importing of classes where it's quite important to provide it and removed where class is imported and not used in code block. Commits ------- a89cfa3 Add missing imports and remove useless
This PR was merged into the 4.1 branch. Discussion ---------- Add missing imports and remove useless I added importing of classes where it's quite important to provide it and removed where class is imported and not used in code block. This PR is similar to #10817, but here are changes that are actual for v4.1 and aren't for v3.4. Commits ------- f1e1bd0 Add missing imports and remove useless
I added importing of classes where it's quite important to provide it and removed where class is imported and not used in code block.