Update console.rst: reversing constants (logical purpose) #10787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For logical purpose, I added a `!` right before `$this->requirePassword` in the `configure()` method, otherwise the requirePassword argument would be set as REQUIRED instead of OPTIONAL.
ajie62
changed the title
|
It would increase the readability, if we just reversed the two constants, don't you think? |
|
Yes, it would! Anyway, I just wanted to point out the logical issue here. Reversing the two constants would do the job! :) |
Removed the "!" and just reversed the constants as suggested by Jannik Zschiesche
ajie62
changed the title
|
@ajie62 nice first contribution to Symfony Docs! Thanks and congrats on it. We merged it in 3.4 (the oldest maintained branch that contains the error) and we'll merge in the other branches automatically later. |
javiereguiluz
added a commit
that referenced
this pull request
Dec 17, 2018
…) (ajie62) This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #10787). Discussion ---------- Update console.rst: reversing constants (logical purpose) For logical purpose, I added a `!` right before `$this->requirePassword` in the `configure()` method, otherwise the requirePassword argument would be set as REQUIRED instead of OPTIONAL. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 9298445 Update console.rst: reversing constants (logical purpose)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For logical purpose, I added a
!right before$this->requirePasswordin theconfigure()method, otherwise the requirePassword argument would be set as REQUIRED instead of OPTIONAL.