Skip to content

Fix syntax error in decorating services example #10748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2018
Merged

Fix syntax error in decorating services example #10748

merged 1 commit into from
Dec 8, 2018

Conversation

danrot
Copy link
Contributor

@danrot danrot commented Dec 8, 2018

There was a small error in the example for decorating services. This won't bother anybody since it is only an example of generated code, but it still looks weird 🙂

#SymfonyConHackday2018

Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@javiereguiluz
Copy link
Member

Thanks a lot Daniel!

@javiereguiluz javiereguiluz merged commit 1fcf754 into symfony:3.4 Dec 8, 2018
javiereguiluz added a commit that referenced this pull request Dec 8, 2018
This PR was merged into the 3.4 branch.

Discussion
----------

Fix syntax error in decorating services example

There was a small error in the example for decorating services. This won't bother anybody since it is only an example of generated code, but it still looks weird 🙂

#SymfonyConHackday2018

Commits
-------

1fcf754 Fix syntax error in example
@danrot danrot deleted the patch-2 branch December 8, 2018 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants