-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Change setException to setError #10725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The type hint and the use statement should also change since the name is different: https://github.com/symfony/console/blob/master/Event/ConsoleErrorEvent.php it is |
Thank you @kunicmarko20. After validating my own pr I saw:
|
This (method name, import, and typehint) should probably be changed for 3.4 and up since the |
@javiereguiluz what do you suggest? |
The 3.4 doc should indeed be updated to showcase the non-deprecated version of it. |
@Landerstraeten thanks for improving 3.4 code and fixing the other branches code (we'll do that when merging this into 4.1 and higher). Also, congrats on your first Symfony dDocs contribution! |
This PR was merged into the 3.4 branch. Discussion ---------- Change setException to setError #SymfonyConHackDay2018 Commits ------- d9a5c2a Fix console error event
This PR was merged into the 3.4 branch. Discussion ---------- Change setException to setError #SymfonyConHackDay2018 Commits ------- d9a5c2a Fix console error event
#SymfonyConHackDay2018