Changing the wording around module.exports

[ghost]

Hello!

I just want to point something out here:

Using the commonjs format (require() and module.exports, though node does add some additional things on top of that spec) is not the same, or even roughly the same, which is implied/stated by this line here:

Instead of using require and module.exports like shown above, JavaScript has an alternate syntax, which is a more accepted standard. Choose whichever you want: they do the same thing.

I propose a minor edit here, which is that we actually want to clarify that the ECMAScript standard that has been finalized (often this is known as ES6 or ES2015. There was a minor revision in there but thats long since passed in either case) and one of the purposes, per the Module spec, is that this is the standard for which modules will be native to the browser. (In the evergreen versions of Safari, Chrome, Firefox, and I think even Edge now, you can use <script type="module" src="somemodule.js"> and it will work fine). They are also the only official way of using dynamic imports, as highlighted in your own documentation in a way that I think gets the point across very well.

I think this is very misleading otherwise. You do in fact see a performance decoupling bundling the commonjs modules, as webpack can't take advantage of code splitting with dynamic imports without using ECMAScript modules (more or less, from a high level view).

Of course I'm okay changing whatever wording as needed, but I think we should really point out that require() and import are two very different beasts, and I am happy to write up as to way, give links, etc.

[javiereguiluz]

Thanks for this proposal! I agree with it, but I proposed some minor reword to it. What do you think?

[javiereguiluz]

I propose the following reword to not say "the new finalized" (because that expression won't age well):

Instead of using ``require`` and ``module.exports`` like shown above, JavaScript
provides an alternate syntax based on the `ECMAScript 6 modules`_ that includes
the ability to use dynamic imports.

And at the bottom of the article, the URL for the "ECMAScript 6 modules" link must be added:

.. _`ECMAScript 6 modules`: https://hacks.mozilla.org/2015/08/es6-in-depth-modules/

[javiereguiluz]

Let's revert this change because in most examples the Encore config has multiple lines and we always put the last ; in a new line. Thanks!

[javiereguiluz]

@ProtonScott thanks for this improvement and congrats on your first Symfony Docs contribution! We merged it in 3.4 branch.