Update service_decoration.rst #10654
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it clear that the first paragraph is *not* about decorating a service, but completely overriding it. Decorating is explained in the next paragraph, so the reference to the decorator pattern has been moved there. Otherwise it's easy to get confused when reading the doc. The original text was clear, but the meaning changed when the file was moved, in commit symfony@141e922#diff-ebbbc2e2adacde7254ce22cf2a32198c
kunicmarko20
approved these changes
Nov 9, 2018
nicolas-grekas
approved these changes
Nov 10, 2018
|
Thank you @nclavaud. |
xabbuh
added a commit
that referenced
this pull request
Nov 11, 2018
This PR was squashed before being merged into the 2.8 branch (closes #10654). Discussion ---------- Update service_decoration.rst Make it clear that the first paragraph is *not* about decorating a service, but completely overriding it. Decorating is explained in the next paragraph, so the reference to the decorator pattern has been moved there. Otherwise it's easy to get confused when reading the doc. The original text was clear, but then the meaning changed when the file was moved, in commit 141e922#diff-ebbbc2e2adacde7254ce22cf2a32198c <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 0386306 Update service_decoration.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it clear that the first paragraph is not about decorating a service, but completely overriding it. Decorating is explained in the next paragraph, so the reference to the decorator pattern has been moved there. Otherwise it's easy to get confused when reading the doc.
The original text was clear, but then the meaning changed when the file was moved, in commit 141e922#diff-ebbbc2e2adacde7254ce22cf2a32198c