Http kernel controller arguments #10640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ottaviano
force-pushed
the
http-kernel-controller-arguments
branch
from
eb43c48 to
36d3677
Compare
|
The |
|
@nicolas-grekas, it seems that it was not enough as an explication 2 years ago |
javiereguiluz
added a commit
that referenced
this pull request
Apr 5, 2019
This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #10640). Discussion ---------- Http kernel controller arguments Hi, I saw the issue #6854, and I can not write full & clear doc to describe the `kernel.controller_arguments` event. But I think that it will be nice to have this event in the list of all Kernel events. I fix the `kernel.finish_request` event description. This event is triggered after `kernel.response` event (not only for a sub-request). Commits ------- cd5fe5a Http kernel controller arguments
|
Thanks Dimitri! I'm really sorry it took us so long to merge this contribution ... but it's finally merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I saw the issue #6854, and I can not write full & clear doc to describe the
kernel.controller_argumentsevent.But I think that it will be nice to have this event in the list of all Kernel events.
I fix the
kernel.finish_requestevent description. This event is triggered afterkernel.responseevent (not only for a sub-request).