Skip to content

review "best practice" chapter for belittling words #10533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion best_practices/business-logic.rst
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ Both formats have the same performance, so this is ultimately a matter of
personal taste.

We recommend YAML because it's friendly to newcomers and concise. You can
of course use whatever format you like.
use any of the other formats if you prefer another format.

Using a Persistence Layer
-------------------------
Expand Down
2 changes: 1 addition & 1 deletion best_practices/controllers.rst
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ When Things Get More Advanced

The above example works without any configuration because the wildcard name
``{id}`` matches the name of the property on the entity. If this isn't true, or
if you have even more complex logic, the easiest thing to do is just query for
if you have even more complex logic, your best choice is to query for
the entity manually. In our application, we have this situation in
``CommentController``::

Expand Down
4 changes: 2 additions & 2 deletions best_practices/introduction.rst
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ It's also a moving target that will continue to improve.

Keep in mind that these are **optional recommendations** that you and your
team may or may not follow to develop Symfony applications. If you want to
continue using your own best practices and methodologies, you can of course
do it. Symfony is flexible enough to adapt to your needs. That will never
continue using your own best practices and methodologies, you can still do
that. Symfony is flexible enough to adapt to your needs. That will never
change.

Who this Book Is for (Hint: It's not a Tutorial)
Expand Down
2 changes: 1 addition & 1 deletion best_practices/templates.rst
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ Twig Extensions

Our application needs a custom ``md2html`` Twig filter so that we can transform
the Markdown contents of each post into HTML. To do this, create a new
``Markdown`` class that will be used later by the Twig extension. It just needs
``Markdown`` class that will be used later by the Twig extension. It needs
to define one single method to transform Markdown content into HTML::

namespace App\Utils;
Expand Down
4 changes: 2 additions & 2 deletions best_practices/tests.rst
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ functional tests, you can quickly spot any big errors before you deploy them:
Define a functional test that at least checks if your application pages
are successfully loading.

A functional test like this is simple to implement thanks to
:ref:`PHPUnit data providers <testing-data-providers>`::
:ref:`PHPUnit data providers <testing-data-providers>` help you implement
functional tests::

// tests/ApplicationAvailabilityFunctionalTest.php
namespace App\Tests;
Expand Down