Fix base.html.twig path #10522
Merged
Fix base.html.twig path #10522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match Symfony 3.4 structure, as seen here: https://symfony.com/doc/3.4/templating.html
yceruto
reviewed
Oct 19, 2018
| @@ -82,7 +82,7 @@ your layout. In Symfony, use the ``asset()`` helper: | |||
|
|
|||
| .. code-block:: twig | |||
|
|
|||
| {# templates/base.html.twig #} | |||
| {# app/Resources/views/base.html.twig #} | |||
There was a problem hiding this comment.
symfony new my_project 3.4 comes with app/Resources/views/base.html.twig, and the docs reference app/Resources/views/ a lot.
It makes more sense to me. Don't you think?
|
@quentint you are right! In 3.4 branch we still show the old template path. Thanks for fixing this ... and congrats on your first Symfony Docs contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Oct 19, 2018
This PR was merged into the 3.4 branch. Discussion ---------- Fix base.html.twig path To match Symfony 3.4 structure, as seen here: https://symfony.com/doc/3.4/templating.html Commits ------- b572928 Fix base.html.twig path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match Symfony 3.4 structure, as seen here: https://symfony.com/doc/3.4/templating.html