Skip to content

Remove single quotes from namespace #10520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

juanmiguelbesada
Copy link
Contributor

I was trying to migrate and old database and found that using this command with single quotes generates the entities but the files generated contains the namespace single-quoted:

<?php

namespace 'App\Entity';
...

Removing the single quotes when running the command solves the problem.

I was trying to migrate and old database and found that using this command with single quotes generates the entities but the files generated contains the namespace single-quoted:

```php
<?php

namespace 'App\Entity';
...
```

Removing the single quotes when running the command solves the problem.
@javiereguiluz
Copy link
Member

@juanmiguelbesada thanks for reporting this issue. We recently changed this to fix some issues reported by another user.

I've just run this command in the Symfony Demo app:

$ php bin/console doctrine:mapping:import 'App\Entity' annotation --path=src/Entity

And the generated code didn't contain the single quotes:

demo-entity

Could you please tell me which operating system and console application do you use? Thanks!

@juanmiguelbesada
Copy link
Contributor Author

@javiereguiluz you are right

The issue is with phpstorm Embedded local terminal.

Tested with powershell terminal / git bash (for windows) and windows command line and it works perfect.

Closing.

@juanmiguelbesada
Copy link
Contributor Author

@javiereguiluz you are right

The issue is with phpstorm Embedded local terminal.

Tested with powershell terminal / git bash (for windows) and windows command line and it works perfect.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants