Skip to content

Update conditions.rst #10470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 17, 2018
Merged

Update conditions.rst #10470

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a61eb88
Update conditions.rst
kockodev Oct 10, 2018
952b2ac
Update conditions.rst
kockodev Oct 10, 2018
3950895
Update conditions.rst
kockodev Oct 10, 2018
9d84030
Update conditions.rst
kockodev Oct 11, 2018
b506c94
Reword
javiereguiluz Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions routing/conditions.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,3 +87,7 @@ variables that are passed into the expression:

Because of this, using the ``condition`` key causes no extra overhead
beyond the time it takes for the underlying PHP to execute.

.. parameters-block:: Injecting parameters

You can inject container parameters (e.g. `%kernel.environment%`) into condition, such as `@Route(condition="'%kernel.environment' in ['dev']")` or any other you want.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

- @Route(condition="'%kernel.environment' in ['dev']")
+ @Route(condition="'%kernel.environment%' in ['dev']")

???

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OskarStark you have eagle eyes 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣