Fix and improve JSON login docs #10467
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentchalamon
approved these changes
Oct 10, 2018
|
Thanks Kévin! |
javiereguiluz
added a commit
that referenced
this pull request
Oct 10, 2018
This PR was squashed before being merged into the 3.4 branch (closes #10467). Discussion ---------- Fix and improve JSON login docs Since symfony/symfony#22494, it's mandatory to return a valid response in the controller to prevent a 500 error. I've updated the docs accordingly, and added an example of what can be returned. This PR is similar to #9611 (that was right, sorry I just noticed). ping @vincentchalamon Commits ------- 570dce3 Fix and improve JSON login docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since symfony/symfony#22494, it's mandatory to return a valid response in the controller to prevent a 500 error.
I've updated the docs accordingly, and added an example of what can be returned.
This PR is similar to #9611 (that was right, sorry I just noticed).
ping @vincentchalamon