[Validator] Improve condition in if statement #10306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The title of this pull request is "fix condition" ... but the current condition is correct, right? Maybe this is to improve it and make it a bit easier to understand? Thanks! |
|
@javiereguiluz you right, in fact, it may be to "standardize" because I see regularly in the documentation of Symfony that you use this type of condition... |
nicoweb
changed the title
|
Thanks for explaining. I agree with this proposal. Let's merge it. Thanks! |
javiereguiluz
added a commit
that referenced
this pull request
Sep 10, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [Validator] Improve condition in if statement Commits ------- 9919dcc [Validator] fix condition in if statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.