Move range to the comparison constraint types #10249
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexander-schranz thanks for reporting this issue in the first place and for providing a fix for it! |
javiereguiluz
added a commit
that referenced
this pull request
Sep 4, 2018
…-schranz) This PR was squashed before being merged into the 2.8 branch (closes #10249). Discussion ---------- Move range to the comparison constraint types As the [Range](http://symfony.com/doc/3.4/reference/constraints/Range.html) constraint also work for **date** fields the section headline [Number Constraints](http://symfony.com/doc/3.4/reference/constraints.html#number-constraints) is misleading. As I first thought that the Range will work only for numbers then. fixes #10229 Commits ------- 7921ae5 Move range to the comparison constraint types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the Range constraint also work for date fields the section headline Number Constraints is misleading. As I first thought that the Range will work only for numbers then.
fixes #10229