[Security] Expression voter #10236
Closed
[Security] Expression voter #10236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alavieille
force-pushed
the
security_expression_voter
branch
from
6ba75a4 to
fbd8c00
Compare
OskarStark
reviewed
Apr 28, 2019
|
@wouterj I would like to have a review here |
alavieille
force-pushed
the
security_expression_voter
branch
from
fbd8c00 to
f47e911
Compare
| '"ROLE_ADMIN" in roles or (not is_anonymous() and user.isSuperAdmin())' | ||
| ) | ||
|
|
||
| $vote = $expressionVoter->vote($token, $object, array($expression)); |
There was a problem hiding this comment.
Replace array by []
There was a problem hiding this comment.
This should be merged
It is really a component worth knowing :)
|
@alavieille thanks a lot for contributing the docs for this missing feature! We merged it in the 3.4 branch so it's available for all Symfony Doc versions. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding missing documentation of expression voter