Update setup.rst #10185
Merged
Update setup.rst #10185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMO we don't need to download the web server bundle except if we have the skeleton version.
|
You're 100% right @ThamiSadouk - nice catch! I just re-worded things to move that note up a bit (it's tough to try not to interrupt the "flow" for most users... which use |
weaverryan
approved these changes
Aug 18, 2018
xabbuh
approved these changes
Aug 21, 2018
|
Thank you @ThamiSadouk. |
xabbuh
added a commit
that referenced
this pull request
Aug 21, 2018
This PR was merged into the 4.1 branch. Discussion ---------- Update setup.rst IMO we don't need to download the web server bundle except if we have the skeleton version. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 722f5f8 Clarifying when you need to or don't need to install the server bundle 184c298 Update setup.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO we don't need to download the web server bundle except if we have the skeleton version.