Fix typo on which YAML values must not be quoted #10173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello back ;) |
weaverryan
added a commit
that referenced
this pull request
Aug 10, 2018
This PR was merged into the 2.8 branch. Discussion ---------- Fix typo on which YAML values must not be quoted Hello Commits ------- 480954c Fix typo on which YAML values must not be quoted
xabbuh
reviewed
Aug 13, 2018
| @@ -64,7 +64,7 @@ escaped with double quotes: | |||
| ``\x19``, ``\x1a``, ``\e``, ``\x1c``, ``\x1d``, ``\x1e``, ``\x1f``, ``\N``, | |||
| ``\_``, ``\L``, ``\P`` | |||
|
|
|||
| Finally, there are other cases when the strings must be quoted, no matter if | |||
| Finally, there are other cases when the strings must not be quoted, no matter if | |||
There was a problem hiding this comment.
I am afraid there is a misunderstanding here. All the examples below assume that you want them really to be the literal value of your strings. That's why they must be quoted (see the "otherwise" notes after each example).
weaverryan
added a commit
that referenced
this pull request
Aug 18, 2018
…(xabbuh) This PR was merged into the 2.8 branch. Discussion ---------- Revert "Fix typo on which YAML values must not be quoted" see #10173 (comment) Commits ------- c594a3e Revert "Fix typo on which YAML values must not be quoted"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello