Update name of the webpack encore package #10159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webpack-encore is not used in composer
|
It's true that recently we changed the docs to always use the real package name instead of the Flex shortcut ... but maybe here we want to make an exception? Let's ask @weaverryan if he opposes to this. Thanks! |
|
I do disagree with this change. This install doc is all about using Symfony Flex. And so, that package name will work. But, I realize that this is the 3.4 branch, where Flex is not assumed as the default. So, I think we should re-work JUST this branch's docs to make that more obvious. @razbounak Was this the issue? You're on a Symfony 3.4 project, and so aren't using Symfony Flex? Or was there something else confusing? |
|
@weaverryan yes It's only for 3.4 |
javiereguiluz
added
Status: Reviewed
and removed
Status: Needs Review
needs comments
labels
|
Thanks Thomas. |
javiereguiluz
added a commit
that referenced
this pull request
Sep 24, 2018
This PR was merged into the 3.4 branch. Discussion ---------- Update name of the webpack encore package webpack-encore is not used in composer Commits ------- 1e9863c Update name of the webpack encore package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpack-encore is not used in composer