Skip to content

Fixed grammar issue in console.rst #10144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fixed grammar issue in console.rst #10144

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2761ac9
Fixed grammar issue in console.rst
Vafilor Aug 2, 2018
105cc87
Updated console.rst service wording to match 2.8
Vafilor Aug 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion console.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ Now, you can pass the username to the command:
Getting Services from the Service Container
-------------------------------------------

To actually create a new user, the command has to access to some
To actually create a new user, the command has to have access to some
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 2.8, the sentence reads like this: "[...] has to access some [...]" Shouldn't we changed it here accordingly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. Yes, I prefer 2.8's wording.

:doc:`services </service_container>`. Since your command is already registered
as a service, you can use normal dependency injection. Imagine you have a
``AppBundle\Service\UserManager`` service that you want to access::
Expand Down