Add file_relative function to the Twig reference #10115
Conversation
| @@ -637,6 +637,27 @@ file_link | |||
| Generates a link to the provided file and line number using | |||
| a preconfigured scheme. | |||
|
|
|||
| file_relative | |||
There was a problem hiding this comment.
Excuse me for the nitpicking ... but wouldn't |relative_path be a better name than |file_relative for this filter?
There was a problem hiding this comment.
I think so, but that one already exists for urls.
There was a problem hiding this comment.
There was a problem hiding this comment.
At least it is consistent with |file_link filter. Maybe should be |file_relative_path.
There was a problem hiding this comment.
I meant, even if there is no name conflict between functions and filters, it could be confusing to have two helpers with the same name and different goals.
There was a problem hiding this comment.
You are right. Let's keep this name then. Thanks!
There was a problem hiding this comment.
What about relative_file_path instead?
javiereguiluz
added
Missing Documentation
Twig
Status: Reviewed
and removed
Status: Needs Review
labels
|
Thanks Yonel. |
…o, javiereguiluz) This PR was merged into the master branch. Discussion ---------- Add file_relative function to the Twig reference Documenting https://github.com/symfony/symfony/pull/27978/files#diff-f1a4cceb03e213bc53ab3f0ed53b7da5R215 Commits ------- 540817e Final reword 67460dc Reword and added the versionadded directive 3eec2ce Document file_relative Twig function
|
Thanks to you for the new writing, always better! |
Documenting https://github.com/symfony/symfony/pull/27978/files#diff-f1a4cceb03e213bc53ab3f0ed53b7da5R215