Skip to content

Add missing colon to reserved chars #10075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Conversation

lboynton
Copy link
Contributor

Colon is also a reserved char according to PSR-6

Key - A string of at least one character that uniquely identifies a
cached item. Implementing libraries MUST support keys consisting of the
characters A-Z, a-z, 0-9, _, and . in any order in UTF-8 encoding and a
length of up to 64 characters. Implementing libraries MAY support additional
characters and encodings or longer lengths, but must support at least that
minimum. Libraries are responsible for their own escaping of key strings
as appropriate, but MUST be able to return the original unmodified key string.
The following characters are reserved for future extensions and MUST NOT be
supported by implementing libraries: {}()/@:

@javiereguiluz
Copy link
Member

@lboynton thanks for improving this ... and congrats on your first Symfony Docs contribution!

@javiereguiluz javiereguiluz merged commit a9331a8 into symfony:3.4 Jul 18, 2018
javiereguiluz added a commit that referenced this pull request Jul 18, 2018
This PR was merged into the 3.4 branch.

Discussion
----------

Add missing colon to reserved chars

Colon is also a reserved char according to PSR-6

>Key - A string of at least one character that uniquely identifies a
cached item. Implementing libraries MUST support keys consisting of the
characters A-Z, a-z, 0-9, _, and . in any order in UTF-8 encoding and a
length of up to 64 characters. Implementing libraries MAY support additional
characters and encodings or longer lengths, but must support at least that
minimum. Libraries are responsible for their own escaping of key strings
as appropriate, but MUST be able to return the original unmodified key string.
The following characters are reserved for future extensions and MUST NOT be
supported by implementing libraries: {}()/\@:

Commits
-------

a9331a8 Add missing colon to reserved chars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants