Remove deleted RoleInterface #10058
Closed
Remove deleted RoleInterface #10058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the master branch of symfony/symfony deleted the Symfony\Component\Security\Core\Role\RoleInterface as of 4.0, this update remove the interface to only mention the base class.
javiereguiluz
added a commit
that referenced
this pull request
Jul 14, 2018
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #10058). Discussion ---------- Remove deleted RoleInterface As the master branch of symfony/symfony deleted the Symfony\Component\Security\Core\Role\RoleInterface as of 4.0, this update remove the interface to only mention the base class. Commits ------- c410eb0 Reword a494993 Remove deleted RoleInterface
|
@Aluok very nice catch! We reworded it a bit and merged it in 3.4. We'll merge it in the upper branches automatically later. Congrats on your first Symfony Docs contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the master branch of symfony/symfony deleted the Symfony\Component\Security\Core\Role\RoleInterface as of 4.0, this update remove the interface to only mention the base class.