Removed the code of the PHP templates #10014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added a commit
that referenced
this pull request
Jul 5, 2018
This PR was merged into the 2.8 branch. Discussion ---------- Removed the code of the PHP templates We tried to do this in the past but I failed at creating the needed PHP script to do this automatically. Now this is ready so we can finally do it. The Symfony Docs team decided to do this because we don't have enough resources to maintain the docs and we need to simplify things. We asked and almost 100% of Symfony developers use Twig for templates, so it doesn't make sense to maintain something that nobody uses. We'll maintain a single article dedicated to explain how to create PHP templates in Symfony apps. But that's all. Commits ------- 88c2163 Removed the code of the PHP templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tried to do this in the past but I failed at creating the needed PHP script to do this automatically. Now this is ready so we can finally do it.
The Symfony Docs team decided to do this because we don't have enough resources to maintain the docs and we need to simplify things. We asked and almost 100% of Symfony developers use Twig for templates, so it doesn't make sense to maintain something that nobody uses. We'll maintain a single article dedicated to explain how to create PHP templates in Symfony apps. But that's all.