…a manifest JSON file (weaverryan) This PR was squashed before being merged into the 3.3-dev branch (closes #22046). Discussion ---------- [Asset] Adding a new version strategy that reads from a manifest JSON file | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | symfony/symfony-docs#7659 Hi guys! Often, when using a frontend task manager or bundler (e.g. webpack of gulp), the final assets are dumped with a version or content hash in the filename itself (e.g. main.123abc.css). To know what the correct, current hashed filename is, you'll dump a `manifest.json` file - e.g. ```json { "main.js": "main.123abc.js", "css/styles.css": "css/styles.555def.css" } ``` Examples: [gulp-rev](https://github.com/sindresorhus/gulp-rev) and [webpack-manifest-plugin](https://www.npmjs.com/package/webpack-manifest-plugin). This PR adds a new version strategy that will look up the asset path (e.g. `main.css`) in that file and return the final, versioned path. Some people may dump manifest files in other formats, but I think this catches the most common use-case (and you can always still create your own version strategy). I've written this to be "forgiving" - if a path doesn't exist in the manifest, the path is simply returned, unaltered. Another implementation *could* have been to add a new Twig filter (e.g. `{{ asset('main.css|manifest_path) }}`) - but I thought I'd try first using the existing versioning system. ## Usage ```yml # app/config/config.yml framework: # ... assets: # added validation prevents you from setting json_manifest_path AND version, for example json_manifest_path: '%kernel.root_dir%/../web/manifest.json' ``` ```twig {# someTemplate.html.twig #} {# use asset() just like normal #} <script src="{{ asset('js/main.js') }}"></script> ``` ## TODO * fabbot hates my invalid json syntax file... even though I tried to be clever and not give it a `.json` suffix :) Commits ------- 07fec2b [Asset] Adding a new version strategy that reads from a manifest JSON file

Uh oh!

Added a new asset versioning strategy that reads a manifest JSON file #7659

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions