Coding standard "arguments on the same line"

[leofeyer]

I am referring to this:

symfony-docs/contributing/code/standards.rst

Lines 182 to 183 in dc9a534

	* Declare all the arguments on the same line as the method/function name, no
	matter how many arguments there are;

Now that we have constructor property promotion in PHP 8, do you still feel like this rule makes sense? Especially constructors can become quite long, e.g.:

class Request
{
    public function __construct(public array $query = [], public array $request = [], public array $attributes = [], public array $cookies = [], public array $files = [], public array $server = [], protected string|object|false|null $content = null)
    {
        $this->initialize($query, $request, $attributes, $cookies, $files, $server, $content);
    }
}

Compared to:

class Request
{
    public function __construct(
        public array $query = [],
        public array $request = [],
        public array $attributes = [],
        public array $cookies = [],
        public array $files = [],
        public array $server = [],
        protected string|object|false|null $content = null
    ) {
        $this->initialize($query, $request, $attributes, $cookies, $files, $server, $content);
    }
}

I realize that you are not promoting constructor property promotion yet (as explained in #16087) and I also realize that nobody has to adopt the Symfony coding style if they don‘t agree with it. However, removing that rule does not mean that anyone (including Symfony) has to change their code, so I figured we could at least discuss it.

What do you think?

[nicolas-grekas]

to me: property promotion = multiline (with trailing comma), single line otherwise (no trailling comma)

[xabbuh]

I agree with Nicolas

[wouterj]

I agree with Nicolas as well (although I'm not a fan of trailing comma in param lists).

I don't think removing the rule, while it is true and the easiest, is the best solution here. Symfony is a bit different to many other projects in that we fully respect the pixels at the right side of your screen, and thus we don't maintain a maximum line length. Let's be explicit about that (to avoid people, after reading the CS, to still contribute wrapped parameter lists).

Would you be able to create a PR to add the property promotion exception to this rule?