[phpunit-bridge] Correctly handling locale

[melkamar]

Some of our unit tests break when using phpunit-bridge due to this "feature":

Forces the tests to use a consistent locale (C);

There is no further documentation about this.

• Can the default locale be changed to something else than C?
• What is the proper way to write code that depends on the locale? Are we supposed to explicitly call setlocale() in every function that needs it so that granular unit tests pass?

[raymondschouten]

Same issue here... Forcing the locale to "C" makes iconv unable to transliterate accents and now completely removes accented characters as being "invalid".

For now I have "fixed" this issue by adding a line to my PHPUnit bootstrap file:

setlocale(LC_CTYPE, 'en_US.UTF-8');

[javiereguiluz]

@nicolas-grekas quick question: does this look like a bug on the code ... or is this expected and something to be documented? Thanks.

[nicolas-grekas]

Phpunit provides a setLocale method for locale-sensitive tests, see e.g. https://git.higidi.com/TYPO3/TYPO3.CMS/commit/8f997b6de9e227885859740895cfe261705801dd

That's unrelated to the bridge: tests should not be context-dependent

[raymondschouten]

@nicolas-grekas thanks, I was not aware of that method provided by PHPUnit!