removing services_test.yaml from symfony/phpunit-bridge recipe #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Symfony 4.1, you can fetch private services from a test using a special method - creating public aliases is not required anymore.
ghost
deployed
to
nicolas-grekas
approved these changes
Feb 26, 2020
There was a problem hiding this comment.
Maybe move the removed comment next to symfony/symfony-docs#12647?
maxhelias
approved these changes
Feb 26, 2020
fabpot
approved these changes
Feb 27, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Symfony 4.1, you can fetch private services from a test using
a special method - creating public aliases is not required anymore.
I'm removing this instead of creating a new version of the recipe mostly for simplicity. The only version that would still need this and is NOT EOL is 3.4. This recipe change would only affect people installing phpunit-bridge into 3.4 today - I think it's worth just keeping the one recipe version. But I can split into a newer version if we want.
Cheers!