[make:user] Use password_hashers instead of encoders #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Jun 3, 2021
wouterj
force-pushed
the
password-hasher
branch
2 times, most recently
from
7f94323 to
76bcefa
Compare
And also improve the position of this config when "enable_authenticator_manager" is the first option.
|
There are all sorts of failures in the tests that I can't explain with my changes - I hope they aren't related. Apart from that, this one should (finally) be ready. |
jrushlow
changed the title
jrushlow
approved these changes
Jun 24, 2021
weaverryan
approved these changes
Jun 25, 2021
| @@ -72,6 +74,10 @@ public function updateForAuthenticator(string $yamlSource, string $firewallName, | |||
| $newData = $this->manipulator->getData(); | |||
|
|
|||
| if (!isset($newData['security']['firewalls'])) { | |||
| if ($newData['security']) { | |||
| $newData['security']['_firewalls'] = $this->manipulator->createEmptyLine(); | |||
| } | |||
There was a problem hiding this comment.
What is this for? Are we suddenly missing an empty line somewhere?
Nevermind - I see that we're now handling some more complex cases than before with placement, etc
|
This is quite thorough and complex - thank you Wouter! |
Merged
weaverryan
added a commit
that referenced
this pull request
Jul 1, 2021
This PR was merged into the 1.0-dev branch. Discussion ---------- [release] v1.33.0 Hi Makers! Insert clever words here ## [v1.33.0](https://github.com/symfony/maker-bundle/releases/tag/v1.33.0) *June 30th, 2021* ### Feature - [#895](#895) - [make:crud] send the proper HTTP status codes and use renderForm() when available - *`@dunglas`* - [#889](#889) - [make:user] Use password_hashers instead of encoders - *`@wouterj`* ### Bug Fix - [#913](#913) - [make:registration] conditionally generate verify email flash in template - *`@jrushlow`* - [#881](#881) - [make:entity] Fix error when API-Platform is installed. - *`@MichaelBrauner`* Diff: v1.32.0...v1.33.0 Happy making! Commits ------- aa1b721 [release] v1.33.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also improve the position of this config when "enable_authenticator_manager" is the first option.
@jrushlow can you maybe help with the blank line (see failing tests)? I tried some things (including adding a
'_' => $this->manipulator->createEmptyLine()) but all resulted in major failures. Thanks!