bug #869 [make:serializer:encoder] set public constant visibility modifier (jrushlow)

weaverryan · weaverryan · commit c981ac286cfd · 2021-05-04T18:52:37.000-04:00
This PR was merged into the 1.0-dev branch. Discussion ---------- [make:serializer:encoder] set public constant visibility modifier Since PHP 7.1 - class constants can have a visibility modifier. The Symfony coding standards require the visibility modifier to be set. `make:serializer:encoder` now defaults to the `public` modifier for the `FORMAT` const. Commits ------- 82a5ca2 [make:serializer:encoder] set public constant visibility modifier
diff --git a/src/Resources/skeleton/serializer/Encoder.tpl.php b/src/Resources/skeleton/serializer/Encoder.tpl.php
@@ -7,7 +7,7 @@
 
 class <?= $class_name ?> implements EncoderInterface, DecoderInterface
 {
-    const FORMAT = '<?= $format ?>';
+    public const FORMAT = '<?= $format ?>';
 
     public function encode($data, $format, array $context = [])
     {

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`
`8`	`8`	`class <?= $class_name ?> implements EncoderInterface, DecoderInterface`
`9`	`9`	`{`
`10`		`- const FORMAT = '<?= $format ?>';`
	`10`	`+ public const FORMAT = '<?= $format ?>';`
`11`	`11`
`12`	`12`	`public function encode($data, $format, array $context = [])`
`13`	`13`	`{`