Skip to content

Commit c6330a3

Browse files
committed
minor #868 set visibility on class constants (jrushlow)
This PR was merged into the 1.0-dev branch. Discussion ---------- set visibility on class constants sets the visibility modifier for class constants Commits ------- 8b45487 set visibility on class constants
2 parents 012e7f0 + 8b45487 commit c6330a3

File tree

5 files changed

+17
-17
lines changed

5 files changed

+17
-17
lines changed

src/DependencyInjection/CompilerPass/MakeCommandRegistrationPass.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
class MakeCommandRegistrationPass implements CompilerPassInterface
2525
{
26-
const MAKER_TAG = 'maker.command';
26+
public const MAKER_TAG = 'maker.command';
2727

2828
public function process(ContainerBuilder $container)
2929
{

src/Doctrine/EntityRelation.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@
1616
*/
1717
final class EntityRelation
1818
{
19-
const MANY_TO_ONE = 'ManyToOne';
20-
const ONE_TO_MANY = 'OneToMany';
21-
const MANY_TO_MANY = 'ManyToMany';
22-
const ONE_TO_ONE = 'OneToOne';
19+
public const MANY_TO_ONE = 'ManyToOne';
20+
public const ONE_TO_MANY = 'OneToMany';
21+
public const MANY_TO_MANY = 'ManyToMany';
22+
public const ONE_TO_ONE = 'OneToOne';
2323

2424
private $type;
2525

src/Maker/MakeAuthenticator.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@
4747
*/
4848
final class MakeAuthenticator extends AbstractMaker
4949
{
50-
const AUTH_TYPE_EMPTY_AUTHENTICATOR = 'empty-authenticator';
51-
const AUTH_TYPE_FORM_LOGIN = 'form-login';
50+
private const AUTH_TYPE_EMPTY_AUTHENTICATOR = 'empty-authenticator';
51+
private const AUTH_TYPE_FORM_LOGIN = 'form-login';
5252

5353
private $fileManager;
5454

src/Util/ClassSourceManipulator.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@
3535
*/
3636
final class ClassSourceManipulator
3737
{
38-
const CONTEXT_OUTSIDE_CLASS = 'outside_class';
39-
const CONTEXT_CLASS = 'class';
40-
const CONTEXT_CLASS_METHOD = 'class_method';
38+
private const CONTEXT_OUTSIDE_CLASS = 'outside_class';
39+
private const CONTEXT_CLASS = 'class';
40+
private const CONTEXT_CLASS_METHOD = 'class_method';
4141

4242
private $overwrite;
4343
private $useAnnotations;

src/Util/YamlSourceManipulator.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,15 @@
2424
*/
2525
class YamlSourceManipulator
2626
{
27-
const EMPTY_LINE_PLACEHOLDER_VALUE = '__EMPTY_LINE__';
28-
const COMMENT_PLACEHOLDER_VALUE = '__COMMENT__';
27+
public const EMPTY_LINE_PLACEHOLDER_VALUE = '__EMPTY_LINE__';
28+
public const COMMENT_PLACEHOLDER_VALUE = '__COMMENT__';
2929

30-
const UNSET_KEY_FLAG = '__MAKER_VALUE_UNSET';
31-
const ARRAY_FORMAT_MULTILINE = 'multi';
32-
const ARRAY_FORMAT_INLINE = 'inline';
30+
public const UNSET_KEY_FLAG = '__MAKER_VALUE_UNSET';
31+
public const ARRAY_FORMAT_MULTILINE = 'multi';
32+
public const ARRAY_FORMAT_INLINE = 'inline';
3333

34-
const ARRAY_TYPE_SEQUENCE = 'sequence';
35-
const ARRAY_TYPE_HASH = 'hash';
34+
public const ARRAY_TYPE_SEQUENCE = 'sequence';
35+
public const ARRAY_TYPE_HASH = 'hash';
3636

3737
/**
3838
* @var LoggerInterface|null

0 commit comments

Comments
 (0)