Automatically create Docker Compose files when needed #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
commented
Aug 28, 2021
| continue; | ||
| } | ||
|
|
||
| $this->write(sprintf('Adding Docker Compose definitions to "%s"', $dockerComposeFile)); | ||
|
|
||
| $offset = 8; | ||
| $offset = 2; |
There was a problem hiding this comment.
The default indentation for Docker Compose file is 2 spaces. This was not caught before as tests always used an existing file.
dunglas
approved these changes
Aug 28, 2021
nicolas-grekas
added a commit
that referenced
this pull request
Nov 22, 2021
…lex (weaverryan) This PR was merged into the 1.x branch. Discussion ---------- Interactively asking if the user wants Docker support from Flex Hi! After #821 and #788, Docker support is enabled by default. This PR changes that behavior to interactively ask the user want they want: <img width="1134" alt="Screen Shot 2021-11-18 at 11 36 55 AM" src="https://user-images.githubusercontent.com/121003/142457428-a23ea361-6359-481f-9941-5083146e9b3a.png"> This allows users to easily opt out. But it also allows users to immediately opt IN and get the Docker config. I've tested this locally with every combination I could think of :) Cheers! Commits ------- 59c89c1 Interactively asking if the user wants Docker support from Flex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to use Docker support in Flex, you must configure it explicitly in a project (via
symfony composer config extra.symfony.docker truefor instance). But that's not enough. You must also create thedocker-compose.yamlfile. And if you do not also create thedocker-compose.override.yamlfile, you will end up with half of the configuration.In this PR, I propose to create those 2 files automatically if they don't exist when a service should be added by a recipe.
That way, using Docker support is "only" a matter of opting-in via
composer.json./cc @dunglas