Fixed tests on Windows systems #410
Conversation
| clone_folder: c:\projects\symfony-demo | ||
|
|
||
| cache: | ||
| - '%LOCALAPPDATA%\Composer\files' | ||
| - c:\projects\symfony\composer.phar |
| - echo extension=php_fileinfo.dll >> php.ini-max | ||
| - echo extension=php_pdo_sqlite.dll >> php.ini-max | ||
| - echo extension=php_curl.dll >> php.ini-max | ||
| - echo curl.cainfo=c:\php\cacert.pem >> php.ini-max |
There was a problem hiding this comment.
you don't need the distinction between ini-max and ini-min for the demo
| - php ./vendor/bin/phpunit --verbose | ||
| - cd c:\projects\symfony-demo | ||
| - SET X=0 | ||
| - copy /Y c:\php\php.ini-min c:\php\php.ini |
There was a problem hiding this comment.
no need to test twice with different php.ini
| - SET COMPOSER_NO_INTERACTION=1 | ||
| - SET SYMFONY_DEPRECATIONS_HELPER=strict | ||
| - SET ANSICON=121x90 (121x90) | ||
| - SET SYMFONY_PHPUNIT_SKIPPED_TESTS=phpunit.skipped |
There was a problem hiding this comment.
this one is useless. It is specific to the PHPUnit testsuite
| clone_folder: c:\projects\symfony-demo | ||
|
|
||
| cache: | ||
| - '%LOCALAPPDATA%\Composer\files' |
There was a problem hiding this comment.
keeping the composer cache would still be a good idea though (Symfony does not do it due to the magic it does regarding subtree packages built on the fly, but you can do it)
| clone_folder: c:\projects\symfony-demo | ||
|
|
||
| cache: | ||
| - '%LOCALAPPDATA%\Composer\files' | ||
| - c:\projects\symfony-demo\composer.phar | ||
| - .phpunit -> phpunit |
There was a problem hiding this comment.
this one is useless too, as you don't have such special phpunit install
| - cd c:\projects\symfony-demo | ||
| - SET X=0 | ||
| - php vendor/bin/phpunit || SET X=!errorlevel! | ||
| - exit %X% |
There was a problem hiding this comment.
you can remove all the magic regarding X here, as you don't need to run several test commands
|
@stof thanks for your detailed review! This file is getting really polished 😁 |
| - cd %APPVEYOR_BUILD_FOLDER% | ||
| - php ./vendor/bin/phpunit --verbose | ||
| - cd c:\projects\symfony-demo | ||
| - php vendor/bin/phpunit || SET X=!errorlevel! |
There was a problem hiding this comment.
you forgot to remove the || SET X=!errorlevel! part (which is a good way to ensure that the build stay green 😄 as you turn failures into success currently)
Trying to fix the AppVeyor issues by reusing Symfony's
appveyor.ymlfile.